Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure createRoot warning parity with ReactDOM.render #17937

Merged
merged 1 commit into from Jan 30, 2020

Conversation

trueadm
Copy link
Member

@trueadm trueadm commented Jan 30, 2020

This addresses our internal task T52907474. Specifically, we have a bunch of warnings for ReactDOM.render() like if you fail to clear existing React tree, etc. This PR aims are bringing over some of pre-existing warnings to roots, so we don't lose warning coverage.

@trueadm trueadm requested review from bvaughn and gaearon Jan 30, 2020
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team labels Jan 30, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 420b5de:

Sandbox Source
exciting-newton-88hb4 Configuration

@sizebot
Copy link

sizebot commented Jan 30, 2020

Details of bundled changes.

Comparing: b7f217d...420b5de

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js 0.0% -0.0% 53.05 KB 53.05 KB 15.08 KB 15.08 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.95 KB 115.95 KB 37.3 KB 37.3 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.59 KB 60.59 KB 15.99 KB 15.99 KB NODE_DEV
react-dom.profiling.min.js 0.0% -0.0% 119.57 KB 119.57 KB 38.46 KB 38.45 KB UMD_PROFILING
react-dom.development.js +0.1% 0.0% 953.5 KB 954.4 KB 213.83 KB 213.91 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 116.01 KB 116.01 KB 36.63 KB 36.63 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.77 KB 119.77 KB 37.75 KB 37.75 KB NODE_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 703 B 702 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.5 KB 1.49 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 54.78 KB 54.78 KB 15.4 KB 15.4 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 634 B 633 B NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.89 KB 60.89 KB 16.06 KB 16.06 KB UMD_DEV
react-dom.development.js +0.1% 0.0% 959.43 KB 960.34 KB 215.51 KB 215.59 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 420b5de

@sizebot
Copy link

sizebot commented Jan 30, 2020

Details of bundled changes.

Comparing: b7f217d...420b5de

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.47 KB 20.47 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 54.79 KB 54.79 KB 15.4 KB 15.4 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 711 B 710 B UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom.development.js +0.1% 0.0% 959.46 KB 960.36 KB 215.53 KB 215.61 KB UMD_DEV
react-dom.development.js +0.1% 0.0% 953.52 KB 954.43 KB 213.85 KB 213.93 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 135.95 KB 135.95 KB 35.99 KB 35.99 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.93 KB 119.93 KB 37.67 KB 37.67 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 134.84 KB 134.84 KB 35.76 KB 35.76 KB NODE_DEV
ReactDOM-dev.js +0.1% 0.0% 981.15 KB 982.2 KB 216.71 KB 216.81 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 393.42 KB 393.42 KB 71.88 KB 71.88 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.91 KB 60.91 KB 16.07 KB 16.07 KB UMD_DEV
ReactDOM-profiling.js 0.0% -0.0% 404.75 KB 404.75 KB 74.05 KB 74.04 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.23 KB 10.23 KB 3.47 KB 3.47 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 16 KB 15.99 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 698 B 697 B NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 420b5de

Copy link
Member

@gaearon gaearon left a comment

Looks legit.

@trueadm trueadm merged commit 1662035 into facebook:master Jan 30, 2020
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants