-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure createRoot warning parity with ReactDOM.render #17937
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 420b5de:
|
Details of bundled changes.Comparing: b7f217d...420b5de react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Details of bundled changes.Comparing: b7f217d...420b5de react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
56bf79c
to
420b5de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit.
This addresses our internal task T52907474. Specifically, we have a bunch of warnings for
ReactDOM.render()
like if you fail to clear existing React tree, etc. This PR aims are bringing over some of pre-existing warnings to roots, so we don't lose warning coverage.