-
Notifications
You must be signed in to change notification settings - Fork 48.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StrictMode should call sCU twice in DEV #17942
StrictMode should call sCU twice in DEV #17942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between assigning and requesting a review? How can you “assign” a PR to someone? Odd, github.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9682e5b:
|
It's odd, huh? I guess the idea is that you can pick multiple reviewers, then one fo them could self-assign. I'm trying to use both fields to see if it helps get PRs faster :) |
…Mode This landed in 16.13 via facebook/react#17942
…Mode (#2810) This landed in 16.13 via facebook/react#17942
This was an oversight before. Even our docs suggested that sCU should be called twice:
https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects