Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictMode should call sCU twice in DEV #17942

Merged

Conversation

@bvaughn
Copy link
Contributor

bvaughn commented Jan 30, 2020

This was an oversight before. Even our docs suggested that sCU should be called twice:
https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

Copy link
Contributor

threepointone left a comment

What is the difference between assigning and requesting a review? How can you “assign” a PR to someone? Odd, github.

@codesandbox

This comment has been minimized.

Copy link

codesandbox bot commented Jan 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9682e5b:

Sandbox Source
lucid-star-srrvi Configuration
@bvaughn

This comment has been minimized.

Copy link
Contributor Author

bvaughn commented Jan 30, 2020

What is the difference between assigning and requesting a review? How can you “assign” a PR to someone? Odd, github.

It's odd, huh? I guess the idea is that you can pick multiple reviewers, then one fo them could self-assign.

I'm trying to use both fields to see if it helps get PRs faster :)

@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9682e5b

@sizebot

This comment has been minimized.

Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9682e5b

@bvaughn bvaughn merged commit 6ae2c33 into facebook:master Jan 30, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@bvaughn bvaughn deleted the bvaughn:StrictMode-run-shouldComponentUpdate-twice branch Jan 30, 2020
threepointone added a commit to reactjs/reactjs.org that referenced this pull request Mar 4, 2020
…Mode

This landed in 16.13 via facebook/react#17942
threepointone added a commit to reactjs/reactjs.org that referenced this pull request Mar 4, 2020
…Mode (#2810)

This landed in 16.13 via facebook/react#17942
This was referenced Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.