Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictMode should call sCU twice in DEV #17942

Merged

Conversation

bvaughn
Copy link
Collaborator

@bvaughn bvaughn commented Jan 30, 2020

This was an oversight before. Even our docs suggested that sCU should be called twice:
https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team labels Jan 30, 2020
Copy link
Contributor

@threepointone threepointone left a comment

What is the difference between assigning and requesting a review? How can you “assign” a PR to someone? Odd, github.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9682e5b:

Sandbox Source
lucid-star-srrvi Configuration

@bvaughn
Copy link
Collaborator Author

bvaughn commented Jan 30, 2020

What is the difference between assigning and requesting a review? How can you “assign” a PR to someone? Odd, github.

It's odd, huh? I guess the idea is that you can pick multiple reviewers, then one fo them could self-assign.

I'm trying to use both fields to see if it helps get PRs faster :)

@sizebot
Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9682e5b

@sizebot
Copy link

sizebot commented Jan 30, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9682e5b

@bvaughn bvaughn merged commit 6ae2c33 into facebook:master Jan 30, 2020
22 checks passed
@bvaughn bvaughn deleted the StrictMode-run-shouldComponentUpdate-twice branch Jan 30, 2020
threepointone pushed a commit to reactjs/reactjs.org that referenced this issue Mar 4, 2020
threepointone pushed a commit to reactjs/reactjs.org that referenced this issue Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants