Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable shorthand CSS property collision warning #18002

Merged
merged 1 commit into from Feb 10, 2020

Conversation

sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Feb 8, 2020

Originally added in #14181; disabled in #14245. Intention was to enable it in React 16.7 but we forgot.

Fixes #16393.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Feb 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9010d93:

Sandbox Source
nice-cloud-otcbd Configuration
React example Issue #16393

@sizebot
Copy link

@sizebot sizebot commented Feb 8, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 9010d93

@sizebot
Copy link

@sizebot sizebot commented Feb 8, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 9010d93

Copy link
Contributor

@threepointone threepointone left a comment

Could you also rename ReactDOMShorthandCSSPropertyCollision-test.internal.js > ReactDOMShorthandCSSPropertyCollision-test.js. Thanks!

Originally added in facebook#14181; disabled in facebook#14245. Intention was to enable it in React 16.7 but we forgot.
@sophiebits
Copy link
Collaborator Author

@sophiebits sophiebits commented Feb 9, 2020

Renamed the test and removed the feature flag from it.

@threepointone threepointone merged commit 4f71f25 into facebook:master Feb 10, 2020
22 checks passed
@craigkovatch
Copy link

@craigkovatch craigkovatch commented Mar 3, 2020

Three cheers for @sophiebits !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants