-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devtools): Allow editing context value in Provider #18255
Conversation
packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js
Show resolved
Hide resolved
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b66f183:
|
Can we add some tests for this? |
packages/react-devtools-shared/src/devtools/views/Components/SelectedElement.js
Show resolved
Hide resolved
I'd love to but it wasn't clear to me where and how. In previous efforts to work on devtools no tests for the frontend were added: https://github.com/facebook/react/pull/18070/files |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
bump |
@rachelnabors brought this to my attention, and I will be happy to review it– after #19774 lands. (I can handle the conflicts in this PR myself if necessary.) |
Does it make sense to rebase this PR on your branch at this point? Otherwise I can take care of tending to this PR after #19774 lands if I notice merge conflicts. |
Up to you. I'll likely rebase my branch at least once more after I resolve the last outstanding issue or two. After that, it's up to you if you feel up for handling the merge conflicts or handing them off to me. 😄 |
I'll take a look. |
Looks like the code has completely changed. Would take me a bit longer (over the next week) so if you want to get this in earlier it's probably best if you rebase this PR. |
No worries. I can take a look this afternoon. |
Ah, so to clarify: Editing the context value of a modern context Provider works in master now already. Editing the context value of a Consumer works in some cases, but not all:
Going to close this PR down since it no longer seems to be required. 😄 Thanks! |
Awesome, thanks! |
Summary
Allow editing of context values for modern context types.
Test Plan
Verified locally using packages/react-devtools-shell.
master:
pr: