Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string ref cannot be auto converted warning for React.jsxDEV #18354

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

lunaruan
Copy link
Contributor

The string ref cannot be auto converted warning was using the wrong _self. This diff fixes this so it is now using the correct __self

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 20, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9b2895:

Sandbox Source
wizardly-kowalevski-fthv1 Configuration

@sizebot
Copy link

sizebot commented Mar 20, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against c9b2895

@sizebot
Copy link

sizebot commented Mar 20, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against c9b2895

@lunaruan lunaruan merged commit 7c14786 into facebook:master Mar 20, 2020
trueadm pushed a commit to trueadm/react that referenced this pull request Mar 20, 2020
…ebook#18354)

The string ref cannot be auto converted warning was using the wrong _self. This diff fixes this so it is now using the correct __self
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants