Add an option to DevTools to enable double-logging

[Jchinonso]

Summary

We currently plan to suppress double-logging in development by overriding console in #18547. However, this can be confusing for some scenarios and double logging may be preferable in them. This change adds a toggle to DevTools that would allow to re-enable it on this screen:

Test Plan

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4af8e58:

Sandbox	Source
React	Configuration

[sizebot]

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 4af8e58

[sizebot]

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 4af8e58

[bvaughn]

Hi @Jchinonso. What's the purpose of this change?

[Jchinonso]

Hi @Jchinonso. What's the purpose of this change?

@bvaughn #19710 (comment)

[bvaughn]

There are two things that override the console:

1. React itself, before double rendering (in strict mode, DEV only) (see Disable console.logs in the second render pass of DEV mode double render #18547)
2. DevTools, before re-rendering a component to inspect its hooks (see Improving the component logging/debugging experience #15726)

Such a setting as the one you're adding here could be used to control the 2nd (DevTools) but I don't think anyone is asking for us to stop disabling the console in that case– so I assume you're targeting the first (React's disabling of the console, added in #18547).

That code wasn't written to be turned on or off externally (by something like DevTools). It's built into React. Allowing DevTools to control it (via a new setting like the one you're proposing) would require updating React as well.

Not sure how I feel about this feature 😄 but I'll be happy to look over the code when it's ready.

[Jchinonso]

@bvaughn thanks for the clarification, I saw the patching on the console for both devtools and react and was confused on how to approach this. Now i know, i will take the React route

[gaearon]

Thanks for working on this! I think we need to change a few things.

[stale]

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

[eps1lon]

Replaced by #22030