Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename from iterator to iterable and split the functionality #19831

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Rename from iterator to iterable and split the functionality #19831

merged 9 commits into from
Sep 22, 2020

Commits on Sep 14, 2020

  1. rename from iterator to iterable and split the functionality

    @todortotev
    todortotev committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    ca2d02d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. brought back the iterator variable name due to tests failing

    @todortotev
    todortotev committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    60b8bb5 View commit details
    Browse the repository at this point in the history

  2. fix the issue with failing CI

    @todortotev
    todortotev committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2cf0346 View commit details
    Browse the repository at this point in the history

  3. remove parentheses before data

    @todortotev
    todortotev committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ce81af1 View commit details
    Browse the repository at this point in the history

  4. move the check in the iterator case

    @todortotev
    todortotev committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2558946 View commit details
    Browse the repository at this point in the history

  5. check if executing the function returns an object

    @todortotev
    todortotev committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    c629822 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. remove symbol import

    @todortotev
    todortotev committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    cf19623 View commit details
    Browse the repository at this point in the history

  2. modify the check once again

    @todortotev
    todortotev committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    f7052e8 View commit details
    Browse the repository at this point in the history

  3. Added tests and fixed edge cases for DevTools iterator handling

    Brian Vaughn committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    28bb959 View commit details
    Browse the repository at this point in the history