Fix for MessageChannel in Node Envs (#20756) #20790
Conversation
I got it, i will change it |
|
Comparing: 3d10eca...cda9108 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
packages/scheduler/npm/index.js
Outdated
| typeof window.document.createElement !== 'undefined' | ||
| ); | ||
|
|
||
| // Checks if this is global space |
There was a problem hiding this comment.
To catch execution in node environments and use 'unstable_no_dom'.
| expression | node | chrome | react native |
|---|---|---|---|
| globalThis === this | false | true | false |
Sorry if I'm wrong somewhere... I added a more detailed comment to the line.
There was a problem hiding this comment.
I understand your goal, I'm asking what makes this comparison the right one to use from your perspective. Can you explain the reasoning, aside from the fact that it seems to work in your testing?
There was a problem hiding this comment.
I rely on the fact that in the top-level code in a node module, this is equivalent to module.exports and globalThis is equivalent to global. Whereas in the top-level code in a browser, this and globalThis is equivalents to window.
There was a problem hiding this comment.
I also had an assumption that it is necessary to use a condition like:
typeof window !== 'undefined' &&
typeof globalThis !== 'undefined' &&
globalThis === window
|
Thank you for the PR! After more consideration we've landed on a different strategy: #20834 Appreciate your exploration! |
Please, review my PR for fix issue #20756