Don't lower case HTML tags in comparison for built-ins #21155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
approved these changes
Apr 1, 2021
|
Comparing: b9e4c10...26cddcc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
force-pushed
the
partialrenderlowercase
branch
from
26e28a1
to
26cddcc
Compare
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 11, 2021
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 13, 2021
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 19, 2021
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates the "breaking changes" / "fix" that I did in #21153.
This only has effect on things like
const Tag = "Select"; <Tag value="..." />which already warns.This also mimics what we already do on the client.