Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz #21276

Merged
merged 11 commits into from
Jun 14, 2021
Merged

[Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz #21276

merged 11 commits into from
Jun 14, 2021

Commits on Jun 14, 2021

  1. Wire up DOM legacy build

    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    b2b1a1b View commit details
    Browse the repository at this point in the history

  2. Hack to filter extra comments for testing purposes

    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d194f02 View commit details
    Browse the repository at this point in the history

  3. Use string concat in renderToString 

    I think this might be faster. We could probably use a combination of this
technique in the stream too to lower the overhead.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1750318 View commit details
    Browse the repository at this point in the history

  4. Error if we can't complete the root synchronously 

    Maybe this should always error but in the async forms we can just delay
the stream until it resolves so it does have some useful semantics.

In the synchronous form it's never useful though. I'm mostly adding the
error because we're testing this behavior for renderToString specifically.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    e29a506 View commit details
    Browse the repository at this point in the history

  5. Gate memory leak tests of internals 

    These tests don't translate as is to the new implementation and have been
ported to the Fizz tests separately.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    b823403 View commit details
    Browse the repository at this point in the history

  6. Enable Fizz legacy mode in stable

    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    0e3bcb7 View commit details
    Browse the repository at this point in the history

  7. Add wrapper around the ServerFormatConfig for legacy mode 

    This ensures that we can inject custom overrides without negatively
affecting the new implementation.

This adds another field for static mark up for example.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1fcd29c View commit details
    Browse the repository at this point in the history

  8. Wrap pushTextInstance to avoid emitting comments for text in static m… 

    …arkup
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    9e7d2f5 View commit details
    Browse the repository at this point in the history

  9. Don't emit static mark up for completed suspense boundaries 

    Completed and client rendered boundaries are only marked for the client
to take over.

Pending boundaries are still supported in case you stream non-hydratable
mark up.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    38cdc26 View commit details
    Browse the repository at this point in the history

  10. Wire up generateStaticMarkup to static API entry points

    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    b24fbf8 View commit details
    Browse the repository at this point in the history

  11. Mark as renderer for stable 

    This shouldn't affect the FB one ideally but it's done with the same build
so let's hope this works.
    @sebmarkbage
    sebmarkbage committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    c24b569 View commit details
    Browse the repository at this point in the history