-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fizz] Implement Legacy renderToString and renderToNodeStream on top of Fizz #21276
Commits on Jun 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b2b1a1b - Browse repository at this point
Copy the full SHA b2b1a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d194f02 - Browse repository at this point
Copy the full SHA d194f02View commit details -
Use string concat in renderToString
I think this might be faster. We could probably use a combination of this technique in the stream too to lower the overhead.
Configuration menu - View commit details
-
Copy full SHA for 1750318 - Browse repository at this point
Copy the full SHA 1750318View commit details -
Error if we can't complete the root synchronously
Maybe this should always error but in the async forms we can just delay the stream until it resolves so it does have some useful semantics. In the synchronous form it's never useful though. I'm mostly adding the error because we're testing this behavior for renderToString specifically.
Configuration menu - View commit details
-
Copy full SHA for e29a506 - Browse repository at this point
Copy the full SHA e29a506View commit details -
Gate memory leak tests of internals
These tests don't translate as is to the new implementation and have been ported to the Fizz tests separately.
Configuration menu - View commit details
-
Copy full SHA for b823403 - Browse repository at this point
Copy the full SHA b823403View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e3bcb7 - Browse repository at this point
Copy the full SHA 0e3bcb7View commit details -
Add wrapper around the ServerFormatConfig for legacy mode
This ensures that we can inject custom overrides without negatively affecting the new implementation. This adds another field for static mark up for example.
Configuration menu - View commit details
-
Copy full SHA for 1fcd29c - Browse repository at this point
Copy the full SHA 1fcd29cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e7d2f5 - Browse repository at this point
Copy the full SHA 9e7d2f5View commit details -
Don't emit static mark up for completed suspense boundaries
Completed and client rendered boundaries are only marked for the client to take over. Pending boundaries are still supported in case you stream non-hydratable mark up.
Configuration menu - View commit details
-
Copy full SHA for 38cdc26 - Browse repository at this point
Copy the full SHA 38cdc26View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24fbf8 - Browse repository at this point
Copy the full SHA b24fbf8View commit details -
This shouldn't affect the FB one ideally but it's done with the same build so let's hope this works.
Configuration menu - View commit details
-
Copy full SHA for c24b569 - Browse repository at this point
Copy the full SHA c24b569View commit details