Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Fix Client Render after Postpone #27905

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[Fizz] Fix Client Render after Postpone #27905

merged 2 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Add test for erroring after having already postponed a previous sibling 

    This can trigger errors due to invalid injected scripts but doesn't actually
fail anything else. It's a noop.
    @sebmarkbage
    sebmarkbage committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7af755e View commit details
    Browse the repository at this point in the history

  2. Untrack a boundary after it errors 

    If we have already added resumable slots to a boundary we need to undo that
when it errors later.

Ideally, we'd remove the whole parent path in this case. If this is the
only thing that postpones, we incorrectly think there's resumable
slots.
    @sebmarkbage
    sebmarkbage committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    01d4d7a View commit details
    Browse the repository at this point in the history