Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React from 14898b6a9 to a870b2d54 #63976

Closed
wants to merge 1 commit into from
Closed

Update React from 14898b6a9 to a870b2d54 #63976

wants to merge 1 commit into from

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Apr 2, 2024 •
edited

No description provided.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 2, 2024
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-a870b2d54-20240314 environment +1 17.3 MB react-bot
npm/react-dom@18.3.0-canary-a870b2d54-20240314 environment +1 14 MB react-bot
npm/react-server-dom-turbopack@0.0.0-experimental-a870b2d54-20240314 None +1 2.47 MB react-bot
npm/react-server-dom-turbopack@18.3.0-canary-a870b2d54-20240314 None +1 2.21 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-a870b2d54-20240314 None +1 2.52 MB react-bot
npm/react-server-dom-webpack@18.3.0-canary-a870b2d54-20240314 None +1 2.26 MB react-bot
npm/react@0.0.0-experimental-a870b2d54-20240314 environment 0 638 kB react-bot
npm/react@18.3.0-canary-a870b2d54-20240314 environment 0 601 kB react-bot

🚮 Removed packages: npm/react-dom@0.0.0-experimental-14898b6a9-20240318, npm/react-dom@18.3.0-canary-14898b6a9-20240318, npm/react-server-dom-turbopack@0.0.0-experimental-14898b6a9-20240318, npm/react-server-dom-turbopack@18.3.0-canary-14898b6a9-20240318, npm/react-server-dom-webpack@0.0.0-experimental-14898b6a9-20240318, npm/react-server-dom-webpack@18.3.0-canary-14898b6a9-20240318, npm/react@0.0.0-experimental-14898b6a9-20240318, npm/react@18.3.0-canary-14898b6a9-20240318, npm/scheduler@0.0.0-experimental-14898b6a9-20240318, npm/scheduler@0.24.0-canary-14898b6a9-20240318

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Apr 2, 2024 •
edited

Failing test suites

Commit: bd59ec2

pnpm test-dev test/e2e/app-dir/root-layout-redirect/root-layout-redirect.test.ts (PPR)

  • root-layout-redirect > should work using browser
Expand output

● root-layout-redirect › should work using browser

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  28 |       })
  29 |
> 30 |       expect(foundErrors).toBe(false)
     |                           ^
  31 |     })
  32 |   }
  33 | )

  at Object.toBe (e2e/app-dir/root-layout-redirect/root-layout-redirect.test.ts:30:27)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/actions/app-action-form-state.test.ts (PPR)

  • app-dir action useFormState > should support submitting form state with JS
  • app-dir action useFormState > should support hydrating the app from progressively enhanced form request
Expand output

● app-dir action useFormState › should support submitting form state with JS

TIMED OUT: initial-state:test

initial-state

undefined

  642 |
  643 |   if (hardError) {
> 644 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  645 |   }
  646 |   return false
  647 | }

  at check (lib/next-test-utils.ts:644:11)
  at Object.<anonymous> (e2e/app-dir/actions/app-action-form-state.test.ts:21:7)

● app-dir action useFormState › should support hydrating the app from progressively enhanced form request

TIMED OUT: initial-state:test

initial-state

undefined

  642 |
  643 |   if (hardError) {
> 644 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  645 |   }
  646 |   return false
  647 | }

  at check (lib/next-test-utils.ts:644:11)
  at Object.<anonymous> (e2e/app-dir/actions/app-action-form-state.test.ts:47:7)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/hydration-error.test.ts

  • Error overlay for hydration errors > should show error if script is directly placed under html instead of body
Expand output

● Error overlay for hydration errors › should show error if script is directly placed under html instead of body

expect(received).toContain(expected) // indexOf

Expected substring: "In HTML, <script> cannot be a child of <html>.
This will cause a hydration error."
Received string:    "Cannot render a sync or defer <script> outside the main document without knowing its order. Try adding async=\"\" or moving it into the root <head> tag.

  570 |
  571 |     const warning = await session.getRedboxDescriptionWarning()
> 572 |     expect(warning).toContain(
      |                     ^
  573 |       'In HTML, <script> cannot be a child of <html>.\nThis will cause a hydration error.'
  574 |     )
  575 |

  at Script (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/script.js:180:13)
      at html
      at Layout (Server)
  at RedirectErrorBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/redirect-boundary.js:74:9)
  at RedirectBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/redirect-boundary.js:82:11)
  at NotFoundErrorBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/not-found-boundary.js:76:9)
  at NotFoundBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/not-found-boundary.js:84:11)
  at DevRootNotFoundBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/dev-root-not-found-boundary.js:33:11)
  at ReactDevOverlay (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/react-dev-overlay/app/ReactDevOverlay.js:87:9)
  at HotReload (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/react-dev-overlay/app/hot-reloader-client.js:338:11)
  at Router (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/app-router.js:207:11)
  at ErrorBoundaryHandler (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/error-boundary.js:115:9)
  at ErrorBoundary (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/error-boundary.js:162:11)
  at AppRouter (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/components/app-router.js:577:13)
  at ServerRoot (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/app-index.js:112:27)
  at Root (webpack-internal:///(app-pages-browser)../../../../../../node_modules/.pnpm/file+..+next-repo-e5103d2ad3c9a511e65acbfa0a3795a4aa8870d1d29577440910e7fdf51c004a+packages+n_mf6syu3odfmpynk7qettvfeo3q/node_modules/next/dist/client/app-index.js:117:11)"
  at Object.toContain (development/acceptance-app/hydration-error.test.ts:572:21)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

  • app dir - rsc basics > should not use bundled react for pages with app
  • app dir - rsc basics > should use canary react for app
  • app dir - rsc basics > should be able to call legacy react-dom/server APIs in client components
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling ppr
  • app dir - rsc basics > react@experimental > should opt into the react@experimental when enabling taint
Expand output

● app dir - rsc basics › should not use bundled react for pages with app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  494 |
  495 |       ssrAppReactVersions.forEach((version) =>
> 496 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  497 |       )
  498 |
  499 |       const browser = await next.browser('/pages-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:496:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:495:27)

● app dir - rsc basics › should use canary react for app

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  535 |
  536 |       ssrPagesReactVersions.forEach((version) => {
> 537 |         expect(version).toMatch(bundledReactVersionPattern)
      |                         ^
  538 |       })
  539 |
  540 |       const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:537:25)
      at Array.forEach (<anonymous>)
  at Object.forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:536:29)

● app dir - rsc basics › should be able to call legacy react-dom/server APIs in client components

expect(received).toBe(expected) // Object.is equality

Expected: "<div class=\"react-static-markup\">React Static Markup</div>"
Received: ""

  557 |       const $ = await next.render$('/app-react')
  558 |       const content = $('#markup').text()
> 559 |       expect(content).toBe(
      |                       ^
  560 |         '<div class="react-static-markup">React Static Markup</div>'
  561 |       )
  562 |

  at Object.toBe (e2e/app-dir/rsc-basic/rsc-basic.test.ts:559:23)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling ppr

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling taint

expect(received).toMatch(expected)

Expected substring: "-experimental-"
Received string:    ""

  668 |
  669 |           ssrPagesReactVersions.forEach((version) => {
> 670 |             expect(version).toMatch('-experimental-')
      |                             ^
  671 |           })
  672 |
  673 |           const browser = await next.browser('/app-react')

  at toMatch (e2e/app-dir/rsc-basic/rsc-basic.test.ts:670:29)
      at Array.forEach (<anonymous>)
  at forEach (e2e/app-dir/rsc-basic/rsc-basic.test.ts:669:33)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/navigation/navigation.test.ts

  • app dir - navigation > browser back to a revalidated page > should load the page
Expand output

● app dir - navigation › browser back to a revalidated page › should load the page

expect(received).toContain(expected) // indexOf

Expected substring: "Form Submitted."
Received string:    "Form
Push this button to submit the form"

  911 |
  912 |         await retry(async () => {
> 913 |           expect(await browser.elementByCss('body').text()).toContain(
      |                                                             ^
  914 |             'Form Submitted.'
  915 |           )
  916 |         })

  at toContain (e2e/app-dir/navigation/navigation.test.ts:913:61)
  at retry (lib/next-test-utils.ts:730:14)
  at Object.<anonymous> (e2e/app-dir/navigation/navigation.test.ts:912:9)

Read more about building and testing Next.js in contributing.md.

@ztanner ztanner closed this Apr 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding will be requested when the pull request is marked ready for review shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi will be requested when the pull request is marked ready for review huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim will be requested when the pull request is marked ready for review feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh will be requested when the pull request is marked ready for review wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ztanner @ijjk