Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate renderToStaticNodeStream (#28872) #28874

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 19, 2024

This commit adds warnings indicating that renderToStaticNodeStream will be removed in an upcoming React release. This API has been legacy, is not widely used (renderToStaticMarkup is more common) and has semantically eqiuvalent implementations with renderToReadableStream and renderToPipeableStream.

landed in main in #28872
changed the warning to match renderToNodeStream

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2024
This commit adds warnings indicating that `renderToStaticNodeStream`
will be removed in an upcoming React release. This API has been legacy,
is not widely used (renderToStaticMarkup is more common) and has
semantically eqiuvalent implementations with renderToReadableStream and
renderToPipeableStream.
@gnoff gnoff force-pushed the 18-3-deprecate-rendertostaticnodestream branch from 0d4e24b to baacaf0 Compare April 19, 2024 02:12
@gnoff gnoff merged commit fffddaa into facebook:18-3 Apr 19, 2024
35 checks passed
@gnoff gnoff deleted the 18-3-deprecate-rendertostaticnodestream branch April 19, 2024 15:18
acdlite pushed a commit that referenced this pull request Apr 23, 2024
This commit adds warnings indicating that `renderToStaticNodeStream`
will be removed in an upcoming React release. This API has been legacy,
is not widely used (renderToStaticMarkup is more common) and has
semantically eqiuvalent implementations with renderToReadableStream and
renderToPipeableStream.

landed in main in #28872 
changed the warning to match renderToNodeStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants