compiler: allow reordering of loadlocal after last assignment #29668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
May 30, 2024
ghstack-source-id: f134097b97884f63f4f9d7c643839eb07c83deee Pull Request resolved: #29668
facebook-github-bot
added
CLA Signed
React Core Team
…ent" [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
May 30, 2024
ghstack-source-id: 804744fb562ea3639090a0c4c6cefa871a6aa9c0 Pull Request resolved: #29668
|
Comparing: c4b433f...a1bd51e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
…ent" Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable. Thus if we have: ``` t0 = StoreLocal const x = ... t1 = LoadLocal x t2 = foo t3 = bar t1 # t1 used here ``` We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used: ``` t0 = StoreLocal const x = ... t2 = foo t1 = LoadLocal x t3 = bar t1 ``` Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
May 30, 2024
Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable. Thus if we have: ``` t0 = StoreLocal const x = ... t1 = LoadLocal x t2 = foo t3 = bar t1 # t1 used here ``` We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used: ``` t0 = StoreLocal const x = ... t2 = foo t1 = LoadLocal x t3 = bar t1 ``` Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR. ghstack-source-id: 804744fb562ea3639090a0c4c6cefa871a6aa9c0 Pull Request resolved: #29668
…ent" Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable. Thus if we have: ``` t0 = StoreLocal const x = ... t1 = LoadLocal x t2 = foo t3 = bar t1 # t1 used here ``` We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used: ``` t0 = StoreLocal const x = ... t2 = foo t1 = LoadLocal x t3 = bar t1 ``` Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
Jun 3, 2024
Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable. Thus if we have: ``` t0 = StoreLocal const x = ... t1 = LoadLocal x t2 = foo t3 = bar t1 # t1 used here ``` We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used: ``` t0 = StoreLocal const x = ... t2 = foo t1 = LoadLocal x t3 = bar t1 ``` Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR. ghstack-source-id: 8781cb6763f87a593b92583df6a3fbc368e078e7 Pull Request resolved: #29668
josephsavona
commented
Jun 3, 2024
| t1 = $[2]; | ||
| } | ||
| return t1; | ||
| return <>{posts}</>; |
There was a problem hiding this comment.
this is weird. technically correct - posts will always invalidate, so no point memoizing the jsx - but i want to double-check why the memo is getting removed here
…ent" Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable. Thus if we have: ``` t0 = StoreLocal const x = ... t1 = LoadLocal x t2 = foo t3 = bar t1 # t1 used here ``` We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used: ``` t0 = StoreLocal const x = ... t2 = foo t1 = LoadLocal x t3 = bar t1 ``` Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Extends the instruction reordering from the previous PR to allow reordering LoadLocal, but only after the last assignment of the loaded variable.
Thus if we have:
We know that x isn't assigned after the first instruction, and can safely reorder the loadlocal to where it's first used:
Note that this assumes each LoadLocal temporary is used exactly once, which we already guarantee in BuildHIR.