-
Notifications
You must be signed in to change notification settings - Fork 49.4k
Description
There are two files which have an –
(en-dash) in their fliename instead of the normal -
.
The offending files are:
https://github.com/facebook/react/blob/main/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/functionexpr%E2%80%93conditional-access.expect.md
and
https://github.com/facebook/react/blob/main/compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/functionexpr%E2%80%93conditional-access.js
I found this because I'm working on a tool that parses git history and when I decided to test it on the react codebase I got some very cryptic errors because the en-dashes in those filenames had gotten replaced with \342\200\223. My tool can deal with en-dashes in the filenames now but I'm still reporting this because filenames should follow a convention and en-dashes are not part of that convention.