Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for babel 6 #5348

Merged
merged 1 commit into from
Oct 31, 2015
Merged

add docs for babel 6 #5348

merged 1 commit into from
Oct 31, 2015

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Oct 31, 2015

Should probably include es2015 but it doesn't apply for this particular example?

@weaselandfox
Copy link

Could this please be reviewed and merged?

@facebook-github-bot
Copy link

@hzoo updated the pull request.

@facebook-github-bot
Copy link

@hzoo updated the pull request.

@zpao
Copy link
Member

zpao commented Oct 31, 2015

@puhastudio Please check your entitlement. This is an open source project, it's Saturday morning, Babel 6 came out 2 days ago, and we have lives. We're not all here 10 minutes after every pull request.

@hzoo Thanks for this! I wouldn't be surprised if people use that as source of truth so it's probably worth adding a link to the blog post (since the docs aren't all updated) or adding something about es2015 preset as well for those using it, even if the example here doesn't.

@weaselandfox
Copy link

@zpao I'm sorry, forgot to check dates and times.

@hzoo
Copy link
Contributor Author

hzoo commented Oct 31, 2015

@zpao Yep true that. I'l add a link to the post and include the es2015 preset

@facebook-github-bot
Copy link

@hzoo updated the pull request.

@zpao
Copy link
Member

zpao commented Oct 31, 2015

Thanks @hzoo!

zpao added a commit that referenced this pull request Oct 31, 2015
@zpao zpao merged commit 88bae3f into facebook:master Oct 31, 2015
zpao added a commit that referenced this pull request Oct 31, 2015
add docs for babel 6
(cherry picked from commit 88bae3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants