Establish a convention for forcing jsx rebuilds #535
Conversation
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| var grunt = require('grunt'); | |||
|
|
|||
| // Increment this number to trigger a full rebuild in rare cases when the | |||
| // JSX transform toolchain is altered in ways not visible to Commoner/JSX. | |||
| var commonerCacheBuster = 1; | |||
There was a problem hiding this comment.
So, in order for this to work we'll need to remember to modify this value when one of those files changes?
How will we remember to do that?
Seems like the sort of thing that will happen a few times and then we'll forget about it.
There was a problem hiding this comment.
I'm going to turn that question back to you: can you think of a good way to remind us, or a better solution? This pull request makes it possible for one mindful person to prevent confusion for everyone, and that's a step in the right direction.
There was a problem hiding this comment.
Can you make this a "CONSTANT"?
Also, is this something that we want to put into package.json and read from there in bin/jsx[-internal]? The change that prompted this wouldn't matter publicly but we talked about that before (changes to jsx formatting, which are likely to come soon).
|
ping |
Pull request facebook#526 updated the behavior of vendor/constants.js without changing any source files or the bin/jsx-internal script, so files that should have been rebuilt (like utils/__tests__/ImmutableObject-test.js) were not automatically rebuilt (unless you knew to do `grunt clean` or `rm -rf .module-cache` manually). This commit allows us to bump a version number when we know the transform toolchain has been altered in a way that will not be visible to commoner/jsx. With this convention, if we reset to an older revision (e.g. during a git bisect) and the appropriate cached module files are still in the .module-cache/, they can be used without rebuilding. That's why I prefer this approach to just deleting the .module-cache/. Closes facebook#104. Closes facebook#496. Closes facebook#530.
|
👍 |
Establish a convention for forcing jsx rebuilds.
Pull request #526 updated the behavior of
vendor/constants.jswithout changing any source files or thebin/jsx-internalscript, so files that should have been rebuilt (likeutils/__tests__/ImmutableObject-test.js) were not automatically rebuilt (unless you knew to dorm -rf .module-cachemanually).This commit allows us to bump a version number (
commonerCacheBuster) when we know the transform toolchain has been altered in a way that will not be visible to commoner/jsx.With this convention, if we reset to an older revision (e.g. during a
git bisect) and the appropriate cached module files are still in the.module-cache/, they can be used without rebuilding. That's why I prefer this approach to just deleting the.module-cache/.cc @subtleGradient @zpao
Closes #104.
Closes #496.
Closes #530.