Use explicit pass for restoring controlled state instead of asap #8176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2016
sophiebits
approved these changes
Nov 7, 2016
| @@ -452,6 +455,12 @@ function makeSimulator(eventType) { | |||
| EventPluginHub.enqueueEvents(event); | |||
| EventPluginHub.processEventQueue(true); | |||
| }); | |||
| // Normally extractEvent enqueues a state restore, but we'll just always do | |||
| // that. | |||
There was a problem hiding this comment.
Why not leave it in ChangeEventPlugin only for consistency with the non-test env?
There was a problem hiding this comment.
This bypasses the ChangeEventPlugin and creates its own synthetic event. So it doesn't go through that logic.
How would you suggest that I leave it in ChangeEvent? Expose something only for testing?
There was a problem hiding this comment.
Ah got it, I was thinking this was SimulateNative. I'm good with this.
This gets rid of the first class ReactUpdates.asap scheduling. Instead of scheduling a first class function to invoke later, I introduce an explicit phase for restoring controlled state after dispatching events. We assume that the deepest event target is the thing that needs its state restored.
We're now not using anything special about onChange handling in the wrappers. Yay!
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
…ebook#8176) * Use explicit pass for restoring controlled state instead of asap This gets rid of the first class ReactUpdates.asap scheduling. Instead of scheduling a first class function to invoke later, I introduce an explicit phase for restoring controlled state after dispatching events. We assume that the deepest event target is the thing that needs its state restored. * Drop special cases for onChange in wrappers We're now not using anything special about onChange handling in the wrappers. Yay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the first class ReactUpdates.asap scheduling. Instead of scheduling a first class function to invoke later, I introduce an explicit phase for restoring controlled state after dispatching events.
We assume that the deepest event target is the thing that needs its state restored.