-
Notifications
You must be signed in to change notification settings - Fork 47k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link and examples for purecomponents #8477
Add link and examples for purecomponents #8477
Conversation
Also I found some errors on the other page: #8478 |
My overall feeling from this is it places too much emphasis on Since Optimizing Performance already mentions |
I see your point. I didn't get too well your last point, are you suggesting to remove the example and add a heading linking to optimising performance or move the example down to it's own heading ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested above.
How could this happen? I understand that, it might miss renders while data updates using mutations, but how |
Thank you for submitting this PR! 😄 Unfortunately the documentation and source code for reactjs.org has been moved to a different repository: https://github.com/reactjs/reactjs.org I realize this PR is old and there may no longer be interest in seeing it merged. If there is, please open a new PR there. Sorry for the inconvenience! (For more backstory on why we moved to a new repo, see issue #11075) |
Discussed here: #8255 cc @lacker