[Fiber] Relax test about rendering top-level null #8640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
reviewed
Jan 11, 2017
| var div = document.createElement('div'); | ||
| expect(function() { | ||
|
|
||
| if (ReactDOMFeatureFlags.useFiber) { |
There was a problem hiding this comment.
Is @spicyj ok with this divergence? Seems like it would be pretty easy to start relying on this, even accidentally.
sophiebits
reviewed
Jan 11, 2017
| var div = document.createElement('div'); | ||
| expect(function() { | ||
|
|
||
| if (ReactDOMFeatureFlags.useFiber) { |
There was a problem hiding this comment.
@acdlite is going to add a flag for the old behavior which should throw this same error.
There was a problem hiding this comment.
I was going to start working on that—but happy to have @acdlite fix it. I didn't do it initially because I thought we're going to introduce a flag to disable all Fiber features including frags, and do it in a single pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It asserts error but this is no longer supposed to be an error in Fiber.