New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controlList to DOM property whitelist #9940

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@nhunzaker
Collaborator

nhunzaker commented Jun 13, 2017

Addresses #9594. Long term, we can ignore this sort of stuff, but the attribute white list change hasn't landed (will it for 15.x?).

Testing:

I've hoisted this build of React on surge.sh and setup a fiddle:
https://jsfiddle.net/84v837e9/88/

The video tag should correctly receive the controlList attribute.

More info:

@aweary

aweary approved these changes Jun 13, 2017 edited

LGTM, pending doc fix

Show outdated Hide outdated docs/docs/reference-dom-elements.md Outdated
@nhunzaker

This comment has been minimized.

Show comment
Hide comment
@nhunzaker

nhunzaker Jun 13, 2017

Collaborator

Got it. I'll cherry pick to 15.6

Collaborator

nhunzaker commented Jun 13, 2017

Got it. I'll cherry pick to 15.6

@nhunzaker nhunzaker merged commit d715765 into facebook:master Jun 13, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details

@aweary aweary referenced this pull request Jul 13, 2017

Closed

React 15.6.2 Umbrella #10040

6 of 12 tasks complete

@nhunzaker nhunzaker referenced this pull request Aug 10, 2017

Merged

15.6.2 Release Prep #10430

11 of 11 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment