Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Animation priority #9968

Closed
wants to merge 4 commits into from

Commits on Jun 15, 2017

  1. ReactNoop.flush methods return an array of yielded values

    Allows us to make assertions on the values that are yielded when
    performing work. In our existing tests, we do this manually by pushing
    into an array.
    
    ReactNoop.flushThrough extends this concept. It accepts an array of
    expected values and flushes until those values are yielded.
    acdlite committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    82a2893 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2017

  1. Remove Animation priority

    There's no advantage to scheduling updates with animation priority
    versus scheduling sync work inside requestAnimationCallback. So we can
    remove all the animation-specific code. Now there's only one type of
    callback.
    acdlite committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    acaf7b2 View commit details
    Browse the repository at this point in the history
  2. Task work inside batched updates is always sync, even for initial mounts

    Behavior now matches Stack. It's unfortunate that this prevents us
    from unifying SynchronousPriority and TaskPriority.
    acdlite committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    045a9cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db0c13f View commit details
    Browse the repository at this point in the history