[WIP] Add Compressed secondary cache into stress test #10160
Conversation
|
@gitbw95 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
gitbw95
changed the title
…into sec_cache_stress_test_3
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
…into sec_cache_stress_test_3
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
…into sec_cache_stress_test_3
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
Summary: If a secondary cache is configured, its possible that a cache lookup will get a hit in the secondary cache. In that case, the ```LRUCacheShard::Lookup``` doesn't immediately update the ```total_charge``` for the item handle if the ```wait``` parameter is false (i.e caller will call later to check the completeness). However, ```BlockBasedTable::GetEntryFromCache``` assumes the handle is complete and calls ```UpdateCacheHitMetrics```, which checks the usage of the cache item and fails the assert in https://github.com/facebook/rocksdb/blob/main/cache/lru_cache.h#L237 (```assert(total_charge >= meta_charge)```). To fix this, we call ```UpdateCacheHitMetrics``` later in ```MultiGet```, after waiting for all cache lookup completions. Test plan - Run crash test with changes from #10160 Pull Request resolved: #10440 Reviewed By: gitbw95 Differential Revision: D38283968 Pulled By: anand1976 fbshipit-source-id: 31c54ef43517726c6e5fdda81899b364241dd7e1
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
…into sec_cache_stress_test_3
|
@gitbw95 has updated the pull request. You must reimport the pull request before landing. |
|
This PR is replaced by #10442 . |
Summary:
The secondary cache is randomly disabled or enabled with CompressedSecondaryCache.
Test Plan:
make -j24 CRASH_TEST_EXT_ARGS=—duration=960 blackbox_crash_test