Skip to content

Commit bc3bbba

Browse files
RajivTSfacebook-github-bot
authored andcommitted
Remove extend_lifespan method
Summary: Now that lifetime extension is provided by virtue of `labels` in snapshots, there isn't any need to have the `extend_lifespan` method which was supposed to manually push the expiry date every time it is called. More context in this quip: https://fb.quip.com/FO2RAtu5ZHb7 Reviewed By: yancouto Differential Revision: D41520142 fbshipit-source-id: 7c9dad6a097548edb52bb735b41795097e239b30
1 parent 6976dfc commit bc3bbba

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

eden/mononoke/blobstore/ephemeral_blobstore/src/bubble.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -426,10 +426,6 @@ impl Bubble {
426426
repo_config,
427427
}
428428
}
429-
430-
pub async fn extend_lifespan(&self) -> Result<()> {
431-
unimplemented!()
432-
}
433429
}
434430

435431
// These blobstore methods are not to be used directly as they bypass redaction.

eden/mononoke/blobstore/ephemeral_blobstore/src/store.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ struct RepoEphemeralStoreInner {
4747
pub(crate) connections: SqlConnections,
4848

4949
/// Initial value of the lifespan for bubbles in this store, i.e. the
50-
/// amount of time they last from either the call to create or the last
51-
/// call to extend_lifespan.
50+
/// amount of time they last from the call to create.
5251
pub(crate) initial_bubble_lifespan: ChronoDuration,
5352

5453
/// Grace period after bubbles expire during which requests which have

0 commit comments

Comments
 (0)