add Troubleshooting section for GitHub page #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just ran into an issue where `sl pr` failed to run because I did not have `gh` configured as my Git credential helper. It took me a bit of time to figure this out, so I thought I would add it to the website, though the docs related to GitHub integration are somewhat spread out, so I'm not sure whether this is the best place for it. A dedicated Troubleshooting page might be more appropriate, though such a page should probably have at least two entries? Though perhaps an even better solution is updating the code to recognize this sort of failure and then suggest `gh auth setup-git` directly when it happens. Test Plan: http://localhost:3000/docs/git/intro
|
@bolinfest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.
add Troubleshooting section for GitHub page
I just ran into an issue where
sl prfailed to run because Idid not have
ghconfigured as my Git credential helper.It took me a bit of time to figure this out, so I thought I would
add it to the website, though the docs related to GitHub
integration are somewhat spread out, so I'm not sure whether this
is the best place for it. A dedicated Troubleshooting page might
be more appropriate, though such a page should probably have at
least two entries?
Though perhaps an even better solution is updating the code to
recognize this sort of failure and then suggest
gh auth setup-gitdirectly when it happens.
Test Plan:
http://localhost:3000/docs/git/intro