Add build instructions for Windows #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes #316 Test Plan: http://localhost:3000/docs/introduction/installation
|
@bolinfest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bolinfest merged this pull request in 2857ac6. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
Summary: The latest Homebrew bottles for Apple Sillicon macOS built by our Github Actions were broken, as mentioned in #315 . This was caused due to updating the Formula template used by our Github actions to 3.11 but not updating the Github actions themselves to Python 3.11. This commit fixes that last part. Pull Request resolved: #319 Test Plan: Triggered a [build on a fork of the sapling repo](https://github.com/sggutier/sapling/releases/tag/0.1.20221211-120017-rcd410769), downloaded the bottle built by it, and checked that it ran properly on my M1 mac: ``` $ sl --version Sapling 0.1.20221211-120017-rcd410769 $ file $(which sl) /Users/sggutier/homebrew/bin/sl: Mach-O 64-bit executable arm64 $ otool -L $(which sl) /Users/sggutier/homebrew/bin/sl: /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3) /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60158.100.133) /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0) /Users/sggutier/homebrew/opt/openssl@1.1/lib/libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) /Users/sggutier/homebrew/opt/openssl@1.1/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0) /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1163.100.19) /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11) /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1141.1.0) /Users/sggutier/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/Python (compatibility version 3.11.0, current version 3.11.0) /usr/lib/libresolv.9.dylib (compatibility version 1.0.0, current version 1.0.0) $ sl dbsh -c "import sys; print(sys.version)" 3.11.0 (main, Nov 28 2022, 13:49:33) [Clang 14.0.0 (clang-1400.0.29.202)] $ sl clone https://github.com/sggutier/sapling/ saplingtest && cd saplingtest && sl remote: Enumerating objects: 677771, done. remote: Counting objects: 100% (2847/2847), done. remote: Compressing objects: 100% (1469/1469), done. remote: Total 677771 (delta 1396), reused 2692 (delta 1261), pack-reused 674924 Receiving objects: 100% (677771/677771), 175.60 MiB | 2.59 MiB/s, done. Resolving deltas: 100% (454743/454743), done. From https://github.com/sggutier/sapling * [new ref] 2857ac6 -> remote/main 6535 files updated, 0 files merged, 0 files removed, 0 files unresolved @ 2857ac6 Today at 11:33 mbolin #317 remote/main │ Add build instructions for Windows (#317) ~ $ touch something && sl st warning: watchman has recently started (pid 1093) - operation will be slower than usual ? something $ cd eden/scm && sl root /Users/sggutier/saplingtest ``` Reviewed By: bolinfest Differential Revision: D41921132 Pulled By: sggutier fbshipit-source-id: 0ed4f2d6f214f02669e45c9c4b8cced7de9caa2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.
Add build instructions for Windows
Summary:
Fixes #316
Test Plan:
http://localhost:3000/docs/introduction/installation