Adds optional pipeline to add features to issues #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Testing steps done: python3 -m sapp.cli analyze taint-output.json --add-feature feature:custom-demo-feature --add-feature always-type:scalarResult: |
|
The issues raised by flake8 and black aren't related to this PR. Since, it is persisting, I thought I would fix them for easier work flow for everyone. Hence made a PR: #40 |
r0rshark
suggested changes
Aug 6, 2021
|
@r0rshark pushed the pipeline up the order as discussed. Now it's short and crisp :) (changes screenshot remains the same) |
gbleaney
requested changes
Aug 6, 2021
Adds optional pipeline to add features to all issues using the sapp analyze command. All features provided using the --add-feature flag/option shall be added to all existing issues associated with the run. If no features are provided, the pipeline just passes the input as the output (fall-through). Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
|
@gbleaney thanks for the comments. Fixed all pyre bugs with your suggestions (I had to use |
|
@r0rshark has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional pipeline to add features to all issues using the sapp
analyze command. All features provided using the --add-feature
flag/option shall be added to all existing issues associated with the
run. If no features are provided, the pipeline just passes the input as
the output (fall-through).
Signed-off-by: Abishek V Ashok abishekvashok@gmail.com
Fixes: MLH-Fellowship/pyre-check#47