Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing a typo on props.mdx page, fixed the issue of not copying to clipboard and added 16 to the comment on 06-static-types.mdx #151

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

nelsonuprety1
Copy link
Contributor

@nelsonuprety1 nelsonuprety1 commented Dec 13, 2023

What changed / motivation ?

In this commit, I addressed a typographical error found on the props.mdx page, ensuring accuracy and clarity in the documentation.

Fix for the issue of not copying to the clipboard mentioned in issue #121 , has been proposed with this pull request.

Additionally, I added the number "16" to a comment in the 06-static-types.mdx file to provide context and enhance the comprehensibility of the code. This change aims to improve the overall quality and understanding of the static types section.

These modifications contribute to a more polished and user-friendly documentation experience.

Linked PR/Issues

Additional Context

  • The typo fix in the props.mdx page is crucial for maintaining precision in the documentation, particularly in conveying information about component properties.
  • The Copy to ClipBoard option not working properly Copy to ClipBoard option not working properly for Installation Command  #121 for Installation Command has been fixed with this pr
  • The addition of the number "16" to a comment in the 06-static-types.mdx file serves to provide context and improve the clarity of the associated code. This change aligns with efforts to enhance code readability and understanding.

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2023
@nelsonuprety1 nelsonuprety1 changed the title docs: Fixing a typo on props.mdx page and added 16 to the comment on 06-static-types.mdx docs: Fixing a typo on props.mdx page, fixed the issue of not copying to clipboard and added 16 to the comment on 06-static-types.mdx Dec 13, 2023
@nmn
Copy link
Contributor

nmn commented Dec 13, 2023

This change was just merged. Sorry.

@nmn nmn closed this Dec 13, 2023
@nelsonuprety1
Copy link
Contributor Author

nelsonuprety1 commented Dec 13, 2023

Hi @nmn did you check the fix for 2 other files? Or should i open another PR with those 2 files only? Thank you.

@nmn nmn reopened this Dec 13, 2023
@nmn
Copy link
Contributor

nmn commented Dec 13, 2023

@nelsonuprety1, you can rebase this PR itself. Sorry I missed the other two files.

@nelsonuprety1
Copy link
Contributor Author

@nmn i have done the rebase of this PR. Please kindly check and let me know , thank you.

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nmn nmn merged commit 1f00fe6 into facebook:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants