Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: v0.5.0-beta.1 branch #319

Merged
merged 25 commits into from
Jan 26, 2024
Merged

Release: v0.5.0-beta.1 branch #319

merged 25 commits into from
Jan 26, 2024

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Jan 7, 2024

This is a beta branch for now, do not merge into main.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2024
Copy link

github-actions bot commented Jan 7, 2024

compressed-size: runtime library

Size change: +0.09 kB
Total size: 2.52 kB

Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.04 (3.22) +0.09 (-0.09) +9.9% (-2.6%) 🔴
View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/StyleXSheet.js 1.48 (3.75) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Jan 7, 2024

compressed-size: e2e bundles

Size change: +0.16 kB
Total size: 1128.55 kB

Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.20 (10185.36) +0.02 (-0.00) 0.0% (-0.0%) 🔴
./apps/rollup-example/.build/stylex.css 123.34 (773.82) +0.14 (+0.88) +0.1% (+0.1%) 🔴

@@ -67,7 +67,7 @@ StyleX plugin. See the API reference for more details on the
`@stylexjs/babel-plugin` API.

To make this easier for commonly used packages and meta-frameworks, StyleX
provides (experimental) plugins for Webpack, Rollup, and Next.js.
provides (experimental) plugins for Webpack, Rollup, Next.js and esbuild.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxford comma

Suggested change
provides (experimental) plugins for Webpack, Rollup, Next.js and esbuild.
provides (experimental) plugins for Webpack, Rollup, Next.js, and esbuild.

@@ -20,7 +20,7 @@
"@docusaurus/preset-classic": "2.4.1",
"@mdx-js/react": "^1.6.22",
"@orama/plugin-docusaurus": "^1.2.4",
"@stylexjs/stylex": "0.4.1",
"@stylexjs/stylex": "0.5.0-beta.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we don't use beta channels for other projects, and might instead publish canaries using SHA (or combination of SHA and date) suffixes if a build is being made available for early testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to figure out how to do a SHA hash.

I didn't publish a beta yet, just a couple of alphas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to figure out how to do a SHA hash.

I can't remember if we automatically do anything for React etc, but in my own projects I've just taken 8-9 chars from the git hash at the HEAD commit being canary-published since no extra commit is added for canary releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! That's such a simple solution. Thanks! I'll do that from next time.

@necolas
Copy link
Contributor

necolas commented Jan 14, 2024

FYI I tried the 0.5 alpha and got an error, not sure if it's fixed in this branch

image

dev: true & runtimeInjection: true

@nmn
Copy link
Contributor Author

nmn commented Jan 15, 2024

@necolas That problem should have been fixed in alpha.3, if you're still seeing that problem I might need your help figuring out the root cause.

nmn and others added 9 commits January 25, 2024 15:09
* Fix: Validate options passed into the Babel plugin

* Add full validation for options with good errors
* Docs: Fix code example typo (#290)

* Handle `keyframe` within `defineVars`

* Add test

* Format

* Fix grammar

* Update stylex-validation-define-vars-test.js

---------

Co-authored-by: k14lb3 <76220140+k14lb3@users.noreply.github.com>
* Add eslint-plugin package

* Add initial test suite

* Improve CSS handling and tests

* Address some of the comments

* Add babel scripts for jsx, flow and ts

* Add package diff

* Add snapshots and fix nits

* Fix rename bug

* Add esbuild example app

* Fix incorrect loaders

* Update package-lock.json

* Remove unnecessary file

* Fix some nits in example

* Add additional style to text fixture

* Remove ext from import in example

* Address some of the comments

* Update package-lock.json

* Add missing function call and snapshot

* Remove comment

* Pluralize function name

* Add types

* Fix build script

* Add docs

* Fix tabulation

* Retake snapshots

* Format prettier

* Add more missing types

* Run formatter

* Fix formatting

* Lock dependency and fix import

* Disable unused key

* Add docs

* Update package-lock.json

* Update package-lock.json

* Add snapshots

* Address comments
nmn and others added 14 commits January 25, 2024 15:09
* chore: Prebundle runtime deps
* feat: add `esm` bundle to `@stylexjs/stylex` (#212)
* Add esm modules target
* Add exports field
* Add stylex-inject export

Co-authored-by: Julius <45975811+nedjulius@users.noreply.github.com>
…Name' (#331)

* feat: Add stylex.attrs function for frameworks that expect 'class' over 'className'
* fix: Avoid runtime size regression
* feat: alias path resolution in nextjs using config
* chore: simplify the aliases in nextjs example app
* feat: docs update for aliases config in babel plugin and nextjs plugin

---------

Co-authored-by: k14lb3 <76220140+k14lb3@users.noreply.github.com>
* Fix: Add missing CSS properties to types and ESLint
* Fix: Add webkit-line-clamp properties
* fix: Keep units for 0 within functions
* Update snapshots
---------

Co-authored-by: k14lb3 <76220140+k14lb3@users.noreply.github.com>
@nmn nmn merged commit c2af5dd into main Jan 26, 2024
9 checks passed
@nmn nmn deleted the release/v0.5.0 branch January 26, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants