Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeScript autocomplete issue #68 #84

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

umutbozdag
Copy link
Contributor

This PR solves the problem described within #68.

Can you please check? @nmn

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 7, 2023
@kevintyj
Copy link
Contributor

kevintyj commented Dec 7, 2023

Wohoo! 🎉

@nmn
Copy link
Contributor

nmn commented Dec 7, 2023

Great! Thanks for this fix.

@nmn nmn merged commit 0525cd4 into facebook:main Dec 7, 2023
9 checks passed
@umutbozdag
Copy link
Contributor Author

Kudos to @kevintyj for addressing this!

@hoangngocthanh
Copy link

image
Using latest version 0.3.0 and still not seeing the fix of this PR.
Is there anything that I miss up?

@nmn
Copy link
Contributor

nmn commented Dec 21, 2023

@hoangngocthanh This fix will be in 0.4.0. Stay tuned!

@hoangngocthanh
Copy link

@hoangngocthanh This fix will be in 0.4.0. Stay tuned!

Thanks @nmn

@mrlexz
Copy link

mrlexz commented Dec 22, 2023

many thanks @hoangngocthanh @nmn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants