Fix build with fmt 10 #1141
Closed
Fix build with fmt 10 #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums need to have a format_as overload or to be casted to their underlying type.
6 tasks
|
@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@genevievehelsel merged this pull request in 812e043. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 23, 2023
Summary: Fixes facebook/watchman#1140 Starting version 10, fmt requires enums to be explicitly casted to their underlying type or have a `format_as` overload. This PR addresses this issue by: - defining `format_as` overloads for enums declared within the project, since all enums have type specifier, they can be directly casted to the underlying type. - using `fmt::underlying` for `apache::thrift::transport::TTransportException` since it is provided by a dependency. X-link: facebook/watchman#1141 Reviewed By: xavierd Differential Revision: D50095318 Pulled By: genevievehelsel fbshipit-source-id: 981b5efcfaa63ecb932a59dcac916d524345a247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140
Starting version 10, fmt requires enums to be explicitly casted to their underlying type or have a
format_asoverload.This PR addresses this issue by:
format_asoverloads for enums declared within the project, since all enums have type specifier, they can be directly casted to the underlying type.fmt::underlyingforapache::thrift::transport::TTransportExceptionsince it is provided by a dependency.