Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fdbc543 adds code that relies on C++17-only class template
argument deduction to wdt. However,
CMakeLists.txt
specifies the C++standard used by the project as
set(CMAKE_CXX_STANDARD 14)
. Asa result, the project can no longer be built by following the steps from
the project's documentation because the compilation fails with an error:
We fix the issue by providing explicit template argument for
std::unique_lock
where fdbc543 replacedfolly::SpinLockGuard
withbare
std::unique_lock
.