Fix building via cmake #216
Closed
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit fdbc543 adds code that relies on C++17-only class template argument deduction to wdt. However, `CMakeLists.txt` specifies the C++ standard used by the project as `set(CMAKE_CXX_STANDARD 14)`. As a result, the project can no longer be built by following the steps from the project's documentation because the compilation fails with an error: [ 36%] Building CXX object CMakeFiles/wdt_min.dir/util/FileCreator.cpp.o In file included from wdt/util/FileCreator.cpp:9:0: wdt/util/FileCreator.h: In member function ‘void facebook::wdt::FileCreator::clearAllocationMap()’: wdt/util/FileCreator.h:81:22: error: missing template arguments before ‘guard’ std::unique_lock guard(lock_); ^~~~~ wdt/util/FileCreator.cpp: In member function ‘int facebook::wdt::FileCreator::openForFirstBlock(facebook::wdt::ThreadCtx&, const facebook::wdt::BlockDetails*)’: wdt/util/FileCreator.cpp:98:22: error: missing template arguments before ‘guard’ std::unique_lock guard(lock_); ^~~~~ wdt/util/FileCreator.cpp: In member function ‘bool facebook::wdt::FileCreator::waitForAllocationFinish(int, int64_t)’: wdt/util/FileCreator.cpp:113:24: error: missing template arguments before ‘guard’ std::unique_lock guard(lock_); ^~~~~ CMakeFiles/wdt_min.dir/build.make:206: recipe for target 'CMakeFiles/wdt_min.dir/util/FileCreator.cpp.o' failed make[2]: *** [CMakeFiles/wdt_min.dir/util/FileCreator.cpp.o] Error 1 CMakeFiles/Makefile2:105: recipe for target 'CMakeFiles/wdt_min.dir/all' failed make[1]: *** [CMakeFiles/wdt_min.dir/all] Error 2 We fix the issue by providing explicit template argument for `std::unique_lock` where fdbc543 replaced `folly::SpinLockGuard` with bare `std::unique_lock`.
michel-slm
referenced
this pull request
Apr 20, 2021
Summary: Per D27390136 (fdbc543) / fdbc543, WDT requires C++17 to build (for the refactor replacing `folly::SpinLockGuard` with `std::unique_lock`). Bump the language standard declared in `CMakeLists.txt` so public builds can succeed. Reviewed By: davide125 Differential Revision: D27867115 fbshipit-source-id: 38e9237d31b3750647279e9a5e227249923406f5
|
I don't think this is needed anymore with 0f100c6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fdbc543 adds code that relies on C++17-only class template
argument deduction to wdt. However,
CMakeLists.txtspecifies the C++standard used by the project as
set(CMAKE_CXX_STANDARD 14). Asa result, the project can no longer be built by following the steps from
the project's documentation because the compilation fails with an error:
We fix the issue by providing explicit template argument for
std::unique_lockwhere fdbc543 replacedfolly::SpinLockGuardwithbare
std::unique_lock.