-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: Enable testing in CI #1609
Conversation
This commit fixes error when running playTests.sh in Meson. Mesonbuild runs out of tree, so ./datagen not in `zstd/tests` dir, it lies in <mesonbuilddir>/tests. This leads to ../programs invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to playTests.sh
look okay, but we'll have to see if it is working on BSD and Windows.
Spurious fail in ARM Fuzz test? Could you restart it, @terrelln ? |
Never mind. I force-pushed new changes. |
The failing poolTest is not a problem with meson. It was broken by #1581. I'll let you know when it is fixed. |
Use std=gnu99 to build and test just like `make test`.
c127994
to
8fba4bf
Compare
Run build under release mode for faster test time.
Hm, test-zstd time in Meson is long compare to other build jobs. Mostly Should I change it to release build?
|
Result when tests are built with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
I'll fix the pool test in a separate PR, it has some deadlocks and flakiness problems.
This PR:
One advantage of running meson test on CI is that tests are run
parallel by default. So test time is faster than running test with make.
Closes #1605