Print zlib/lz4/lzma library versions in verbose version output #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrelln
force-pushed
the
verbose-version
branch
from
fc10b0a
to
e60eba5
Compare
Knowing the version of zlib/lz4/lzma we're linking against is very useful for debugging issues with those libraries, so print it out in the verbosity 4 version output. Also print this information at the top of `playTests.sh`.
Cyan4973
reviewed
Jan 28, 2022
| @@ -637,6 +637,11 @@ static void printVersion(void) | |||
| #endif | |||
| DISPLAYOUT("\n"); | |||
| if (g_displayLevel >= 4) { | |||
| /* library versions */ | |||
| DISPLAYOUT("zlib version %s\n", FIO_zlibVersion()); | |||
There was a problem hiding this comment.
Do I understand that a library version is displayed for each and every supported external codec,
irrespective of the fact that zstd was linked to them or not ?
(and display "Unsupported" in this last case)
There was a problem hiding this comment.
Yup. We could change that behavior by gating each of these behind an ifdef check. I figured that since this is in zstd -vvV output, there is not need to make it super pretty. I'm okay either way though, so lmk if you want me to change it.
There was a problem hiding this comment.
It's not urgent indeed. This is a debug print, I think some verbosity is acceptable.
Cyan4973
approved these changes
Jan 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowing the version of zlib/lz4/lzma we're linking against is very
useful for debugging issues with those libraries, so print it out in the
verbosity 4 version output.
Also print this information at the top of
playTests.sh.