Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zdict] Fix static linking only include guards #3372

Merged
merged 1 commit into from
Dec 16, 2022
Merged

[zdict] Fix static linking only include guards #3372

merged 1 commit into from
Dec 16, 2022

Conversation

terrelln
Copy link
Contributor

@terrelln terrelln commented Dec 16, 2022 •
edited
Loading

Fix zdict.h static linking only section so if you include it twice it still exposes the static linking only symbols. E.g. this pattern:

#include <zdict.h>
#define ZDICT_STATIC_LINKING_ONLY
#include <zdict.h>

This can easily happen when a header you include includes zdict.h.

Fixes #3369.

@terrelln
[zdict] Fix static linking only include guards
9869647 
Fix `zdict.h` static linking only section so if you include it twice it
still exposes the static linking only symbols. E.g. this pattern:

```
```

This can easily happen when a header you include includes `zdict.h`.
@terrelln terrelln merged commit 2f7b8d4 into facebook:dev Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zdict.h static linking only section should work even if the header was already included
3 participants
@terrelln @Cyan4973 @facebook-github-bot