fput doesn't work

[tcmulcahy]

(also I believe the docs are incorrect: "Retrieve a file from device." Probably should be "Store a file on the device")

This is what I get when I use it:

$ fb-adb fput /tmp/libkeyboard.so /data/local/tmp/foo.so
fb-adb fput: execvpe("/proc/self/exe"): No such file or directory

[dcolascione]

On what device?

[jbeich]

Are you on Windows or OS X? I can reproduce it with both fb-adb fput and fb-adb fget on FreeBSD where the issue disappears after mounting /proc filesystem locally.

Better not repeat adb mess of platform-specific code: Windows, OS X, Linux, FreeBSD while it could be generic[1][2].

[dcolascione]

You mean, we can use a worse API for the sake of broken systems that are missing important APIs that happen to be accessed by calling open(2) on strings beginning with "/proc"?

I'll work around the lack of /proc/self/exe support, but I'm keeping it in the Linux case, because execing /proc/self/exe is strictly better than execing orig_argv0 when someone might be replacing the program at the same time.

[dcolascione]

Should work now. Thanks for the report.

[tcmulcahy]

Confirmed. Thanks for fixing!