Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

The library doesn't work on 64bit devices #3

Closed
alexcristea opened this issue Mar 5, 2014 · 6 comments
Closed

The library doesn't work on 64bit devices #3

alexcristea opened this issue Mar 5, 2014 · 6 comments

Comments

@alexcristea
Copy link

No description provided.

@alexcristea
Copy link
Author

The project compiles but the shimmering effect is not visible on a 64bit device simulator

@alexcristea alexcristea reopened this Mar 5, 2014
@yusuke024
Copy link

I added #define CGFloat float to the top of FBShimmeringLayer.m and it did shimmer. I think the problem's caused by the fact that CGFloat is 8 bytes on 64-bit and 4 bytes on 32-bit.

@yusuke024
Copy link

Okay, found it. This is because UIAnimationDragCoefficient() returns a very small number on 64-bit devices (5.26354424712089E-315 in my debugger). This shouldn't be a problem on the real devices since they only use this value if TARGET_IPHONE_SIMULATOR.

@grp
Copy link
Contributor

grp commented Mar 6, 2014

Thanks for the report! I'm looking into this now.

@grp
Copy link
Contributor

grp commented Mar 6, 2014

Should be fixed by a03d37e and be4190a.

@grp grp closed this as completed Mar 6, 2014
@alexcristea
Copy link
Author

I am glad I could help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grp @alexcristea @yusuke024