-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useRecoilTransaction API #1085
Closed
Closed
useRecoilTransaction API #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Nicer API for atomic updates. Since this obviates the need for most uses of useRecoilCallback, we can make it its own hook to make it much less cumbersome to use, as well as having less overhead in various ways. Per discussion, rename from 'atomic update' to 'transaction' (internal modules still keep the old name to avoid overlap with transactions generally). The intention is that this API would potentially allow support for async transactions in the future, if we add such support. Reviewed By: drarmstr Differential Revision: D29312126 fbshipit-source-id: 5faa8a5d49a5026bdf82175c33df600d29efaaf0
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Jun 22, 2021
This pull request was exported from Phabricator. Differential Revision: D29312126 |
This pull request has been merged in daada8a. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1085 Nicer API for atomic updates. Since this obviates the need for most uses of useRecoilCallback, we can make it its own hook to make it much less cumbersome to use, as well as having less overhead in various ways. Per discussion, rename from 'atomic update' to 'transaction' (internal modules still keep the old name to avoid overlap with transactions generally). The intention is that this API would potentially allow support for async transactions in the future, if we add such support. Reviewed By: drarmstr Differential Revision: D29312126 fbshipit-source-id: 0c419e4d95bef8f3506d3cb3477a7d41f82ff8c4
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1085 Nicer API for atomic updates. Since this obviates the need for most uses of useRecoilCallback, we can make it its own hook to make it much less cumbersome to use, as well as having less overhead in various ways. Per discussion, rename from 'atomic update' to 'transaction' (internal modules still keep the old name to avoid overlap with transactions generally). The intention is that this API would potentially allow support for async transactions in the future, if we add such support. Reviewed By: drarmstr Differential Revision: D29312126 fbshipit-source-id: 0c419e4d95bef8f3506d3cb3477a7d41f82ff8c4
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1085 Nicer API for atomic updates. Since this obviates the need for most uses of useRecoilCallback, we can make it its own hook to make it much less cumbersome to use, as well as having less overhead in various ways. Per discussion, rename from 'atomic update' to 'transaction' (internal modules still keep the old name to avoid overlap with transactions generally). The intention is that this API would potentially allow support for async transactions in the future, if we add such support. Reviewed By: drarmstr Differential Revision: D29312126 fbshipit-source-id: 0c419e4d95bef8f3506d3cb3477a7d41f82ff8c4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
enhancement
New feature or request
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Nicer API for atomic updates. Since this obviates the need for most uses of useRecoilCallback, we can make it its own hook to make it much less cumbersome to use, as well as having less overhead in various ways. Per discussion, rename from 'atomic update' to 'transaction' (internal modules still keep the old name to avoid overlap with transactions generally).
The intention is that this API would potentially allow support for async transactions in the future, if we add such support.
Reviewed By: drarmstr
Differential Revision: D29312126