Fix log message "Using custom prophet parameters" #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Good catch. Thanks for the fix @andrey-legayev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Robyn
When I submit custom Prophet parameters to robyn_input() as shown below:
Actual result
I see following log message without any custom parameters:
Using custom prophet parameters:Expected result
Using custom prophet parameters: seasonality.modePls review this tiny fix for the log message.
Type of change
How Has This Been Tested?
I run fixed version of Robyn as part of our internal project - everything works fine, log message looks as it should be.
No other issues observed.