Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recode: reduce the size of OutputModels (Part 1) #683

Merged
merged 2 commits into from
Apr 13, 2023
Merged

recode: reduce the size of OutputModels (Part 1) #683

merged 2 commits into from
Apr 13, 2023

Conversation

laresbernardo
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2023
@laresbernardo
Copy link
Collaborator Author

Using demo data, 1 trial and 1000 iterations:

#### Original (main)
> lares::what_size(OutputModels)
[1] "40 Mb"

#### With changes
> lares::what_size(OutputModels)
[1] "39.6 Mb"

@laresbernardo laresbernardo merged commit bce870e into main Apr 13, 2023
@laresbernardo laresbernardo deleted the reducing_object_size_v2 branch April 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gufengzhou gufengzhou Awaiting requested review from gufengzhou

Assignees

@laresbernardo laresbernardo

@michellegrushkometa michellegrushkometa

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @facebook-github-bot @michellegrushkometa