Fb/osmocom working #59
Conversation
…fabfile which erases the existing feb env.
…not on the path in debian (it is in ubuntu). This makes the call explit and the location is the same in both.
| @@ -107,7 +107,7 @@ def package(package_requirements='yes', flavor=''): | |||
| package_python_openbts(package_requirements) | |||
| elif (env.gsmeng == "osmocom"): | |||
| package_python_osmocom(package_requirements) | |||
| package_freeswitch_mod_smpp() | |||
| #package_freeswitch_mod_smpp() | |||
There was a problem hiding this comment.
@kkroo, I think this just needs s/freeswitch_mod_smpp/freeswitch/, correct?
There was a problem hiding this comment.
It should be fine to remove from the package command. Most people will not need to rebuild freeswitch in their development flow
There was a problem hiding this comment.
Makes sense. Let's just remove the call altogether then, not comment it out.
| @@ -107,7 +107,7 @@ def package(package_requirements='yes', flavor=''): | |||
| package_python_openbts(package_requirements) | |||
| elif (env.gsmeng == "osmocom"): | |||
| package_python_osmocom(package_requirements) | |||
| package_freeswitch_mod_smpp() | |||
| #package_freeswitch_mod_smpp() | |||
There was a problem hiding this comment.
Makes sense. Let's just remove the call altogether then, not comment it out.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| directory=/etc/openvpn | |||
|
|
|||
| command=openvpn endaga-vpn-client.conf.noauto | |||
| command=/usr/sbin/openvpn endaga-vpn-client.conf.noauto | |||
|
So should I convert this to include just the removal of the smpp build and the openvpn change? |
|
confirm that the change I pushed works for you too (I did test, but just to be sure). I'm happy with either removing the smpp build or leaving it as it now is, whichever you and @kkroo prefer, just don't have something commented out. The OpenVPN change is the most useful. |
|
i can't test the diff, I work off the open source repo :( I'l let omar call
that ball.
…On Thu, Jun 15, 2017 at 12:10 PM, Steve Muir ***@***.***> wrote:
confirm that the change I pushed works for you too (I did test, but just
to be sure). I'm happy with either removing the smpp build or leaving it as
it now is, whichever you and @kkroo <https://github.com/kkroo> prefer,
just don't have something commented out. The OpenVPN change is the most
useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_rn2yucn3eb1eVt-TTuduJp07uU7Ulks5sEYGcgaJpZM4N6YO5>
.
|
|
I like what @9muir did in making freeswitch build only if you have the source checkout out. Let's use the internal diff. Closing this out |
|
we want the OpenVPN change, can you ( @kheimerl ) just remove the other commit from this PR and reopen it? |
contains fixes to #58 and an issue with the openvpn package. With this in place (and the other workarounds) I got an osmocom vm up and running.