EXC_BAD_ACCESS in dispatchSignalFromSocketCallbackUnlocked ([SRRunloop main])

[michaelkirk]

Abbreviated crash log

0   libobjc.A.dylib                 0x0000000183131bd0 objc_msgSend + 16 (objc-msg-arm64.s:260)
1   CoreFoundation                  0x0000000183a5c424 _inputStreamCallbackFunc + 56 (CFObject.m:1619)
2   CoreFoundation                  0x0000000183a06644 _signalEventSync + 192 (CFStream.c:658)
3   CoreFoundation                  0x0000000183a129b4 _cfstream_solo_signalEventSync + 240 (CFStream.c:703)
4   CoreFoundation                  0x0000000183a0615c _CFStreamSignalEvent + 468 (CFStream.c:911)
5   CFNetwork                       0x00000001840646dc SocketStream::dispatchSignalFromSocketCallbackUnlocked(SocketStreamSignalHolder*) + 64 (SocketStream.cpp:5353)
6   CFNetwork                       0x0000000184064260 SocketStream::socketCallback(__CFSocket*, unsigned long, __CFData const*, void const*) + 268 (SocketStream.cpp:5285)
7   CFNetwork                       0x0000000184064110 SocketStream::_SocketCallBack_stream(__CFSocket*, unsigned long, __CFData const*, void const*, void*) + 88 (SocketStream.cpp:5088)
8   CoreFoundation                  0x0000000183a6d3d8 __CFSocketPerformV0 + 624 (CFSocket.c:2851)
9   CoreFoundation                  0x0000000183a68efc __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24 (CFRunLoop.c:1761)
10  CoreFoundation                  0x0000000183a68990 __CFRunLoopDoSources0 + 540 (CFRunLoop.c:1807)
11  CoreFoundation                  0x0000000183a66690 __CFRunLoopRun + 724 (CFRunLoop.c:2536)
12  CoreFoundation                  0x0000000183995680 CFRunLoopRunSpecific + 384 (CFRunLoop.c:2814)
13  Foundation                      0x000000018438d21c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 308 (NSRunLoop.m:366)
14  Signal                          0x00000001002f5fa8 -[SRRunLoopThread main] + 252 (SRRunLoopThread.m:76)

Full crash log https://gist.github.com/michaelkirk/619026f74616dc1f17e74344af064354

This crash didn't appear until updating from 7373546 to b0aabde, now it's our number one crash. 😨 (Though at a substantially lower rate than #156, so it was a net gain 😉)

Note, we're running a modified version to support our pinning policy - so actually the exact upgrade was from FredericJacobs/SocketRocket@a062cc7 to WhisperSystems@587ad29.

[michaelkirk]

We released with 8096fef and this problem disappeared. Meaning that for the first time, SocketRocket is not our number one crash. (It's 5th (#421) and 12th though 😉 )

Really appreciate the stability improvements happening lately. Thank you! 💌 💌 💌 💌

[nlutsenko]

Whee! So much win!

[revolutionkpi]

I have got this crash a lot of time in 0.5.1 version.