Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Persists the targets acquired by the TargetManager #34

Open
marcoguerri opened this issue Feb 6, 2020 · 4 comments
Open

Persists the targets acquired by the TargetManager #34

marcoguerri opened this issue Feb 6, 2020 · 4 comments

Comments

@marcoguerri
Copy link
Contributor

Right now there is no source of truth that tells which targets were acquired at the beginning of the job, that can be references for example at events submission time. To have a normalized data model, we need to store targets acquired as well.

@xaionaro
Copy link
Contributor

xaionaro commented Mar 2, 2020

Am I understand correctly that the task is effectively to implement targets-lock-reentrance for a job?

@marcoguerri
Copy link
Contributor Author

This was not meant to be about target locking, but basically storing permanently all the information of targets that we acquire. The target locks backed by MySQL are meant to be ephemeral.

The idea here is instead that we need to have a way to normalize the schema when referencing targets. Right now test events for example are not normalized and it should really be fixed...

We would have a surrogate key in a targets table (target_id, although, this name becomes overloaded and we might think of something else instead) and in test events we'd reference that key.

@marcoguerri
Copy link
Contributor Author

I wouldn't merge the concepts of targets and target_locks in a single table for example because we need to keep locking independent of the storage backend.

@xaionaro
Copy link
Contributor

xaionaro commented Mar 3, 2020

I wouldn't merge the concepts of targets and target_locks in a single table for example because we need to keep locking independent of the storage backend.

Sure, I wasn't implying it :)

Right now test events for example are not normalized and it should really be fixed...

Makes sense. OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants