Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support infinity() and NaN() when constructing array in DuckParser #133

Open
shixuan-fan opened this issue Aug 30, 2021 · 1 comment
Open

Comments

@shixuan-fan
Copy link
Contributor

shixuan-fan commented Aug 30, 2021

This is a follow up for #63 (WidthBucketArrayTest#failureForConstant). It could be reproduced by evaluating expression that look like width_bucket(c0, ARRAY[infinity()]) or width_bucket(c0, ARRAY[nan()]). It would fail with the following information:

Exception: VeloxUserError
Error Source: USER
Error Code: UNSUPPORTED
Reason: Array literal elements need to be constant
Retriable: False
Function: parseOperatorExpr
File: /Users/shixuan/presto/velox/velox/duckdb/conversion/DuckParser.cpp
Line: 218
@stale
Copy link

stale bot commented Aug 30, 2022

This issue has been automatically marked as stale because it has not had any activity in the last year. If you feel that this issue is important, add a comment explaining why the issue is still relevant and the stale tag will be removed; otherwise it will be closed in 14 days. This is an attempt to ensure that our open issues remain valuable and relevant so that we can keep track of what needs to be done and prioritize the right things.

@stale stale bot added the stale label Aug 30, 2022
@stale stale bot closed this as completed Sep 14, 2022
@kgpai kgpai reopened this Sep 14, 2022
@stale stale bot removed the stale label Sep 14, 2022
rui-mo pushed a commit to rui-mo/velox that referenced this issue Feb 22, 2023
liujiayi771 pushed a commit to liujiayi771/velox that referenced this issue Mar 3, 2023
liujiayi771 pushed a commit to liujiayi771/velox that referenced this issue Mar 9, 2023
liujiayi771 pushed a commit to liujiayi771/velox that referenced this issue Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants