Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TPC-H query 19 #225

Closed
aditi-pandit opened this issue Sep 16, 2021 · 2 comments
Closed

Fix TPC-H query 19 #225

aditi-pandit opened this issue Sep 16, 2021 · 2 comments
Assignees
@aditi-pandit
Labels
TPC-H

Comments

@aditi-pandit
Copy link
Collaborator

aditi-pandit commented Sep 16, 2021 •
edited
Loading

Fix TPC-H Q19 run. It failed with error "Failed with VeloxUserError: Unsupported input type for the IN predicate: DOUBLE".

Note: This error is a red-herring imo since there isn't an IN predicate using a DOUBLE type in that SQL per se.

Steps to reproduce : Run unit test testTpchQ19 in
java/presto-native-tests/src/test/java/com/facebook/presto/nativeworker/TestHiveTpchQueries.java
@aditi-pandit aditi-pandit changed the title Fix TPC-H Q19 failiure Fix TPC-H query 19 Sep 16, 2021
@yingsu00
Copy link
Collaborator

yingsu00 commented Sep 16, 2021 •
edited
Loading

@aditi-pandit Thanks for creating the issues. It might be more descriptive if we use ""Unsupported input type for the IN predicate: DOUBLE" for VARCHAR type IN predicate (TPCH Q19)" as the issue title. And stack trace would also be helpful for viewers. Same for other issues.

@aditi-pandit aditi-pandit self-assigned this Nov 22, 2021
@aditi-pandit
Copy link
Collaborator Author

#699 should fix the problem

rui-mo pushed a commit to rui-mo/velox that referenced this issue Mar 17, 2023
@JkSelf
Initialize Native code in GlutenDriverPlugin (facebookincubator#225)
db18d77
rui-mo pushed a commit to rui-mo/velox that referenced this issue Apr 25, 2023
@zhejiangxiaomai
Fix velox functions test (facebookincubator#225)
05c7258 
Change back the return type of presto getYear function to int64_t.
Erase row_constructor_with_null in ScalarFunctionRegTest.cpp.
Introduce substring function to spark sql.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditi-pandit aditi-pandit

Labels
TPC-H
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yingsu00 @aditi-pandit