Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setup-centos8.sh #10249

Closed
wants to merge 1 commit into from
Closed

Remove setup-centos8.sh #10249

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jun 18, 2024 •
edited
Loading

This is not required anymore after the Centos9 upgrade which introduced setup-centos9.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2024
@majetideepak majetideepak requested a review from kgpai June 18, 2024 11:03
@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 4ed72ba
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66762331fded320008ae2f72

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jun 19, 2024
@facebook-github-bot
Copy link
Contributor

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@bikramSingh91
Copy link
Contributor

@majetideepak do you mind rebasing? looks like there is a merge conflict and my land attempt failed due to that. Thanks!

@majetideepak
Copy link
Collaborator Author

@bikramSingh91 done!

@facebook-github-bot
Copy link
Contributor

@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bikramSingh91 merged this pull request in 82a12e1.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 82a12e16.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

marin-ma added a commit to oap-project/velox that referenced this pull request Jun 25, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
5d69b45 
This reverts commit 82a12e1.
marin-ma added a commit to oap-project/velox that referenced this pull request Jun 26, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
97c9366 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jun 27, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
dc3f229 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jun 28, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
1cddb86 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jun 29, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
033a2e3 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jun 30, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
3b138e5 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 2, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
ddde413 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 3, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
a91fb68 
This reverts commit 82a12e1.
PHILO-HE pushed a commit to oap-project/velox that referenced this pull request Jul 3, 2024
@marin-ma @PHILO-HE
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
fc0b9fa 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 4, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
1eaefa6 
This reverts commit 82a12e1.
marin-ma added a commit to oap-project/velox that referenced this pull request Jul 4, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
529f077 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 5, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
400de22 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 6, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
2f6e695 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 7, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
f74f395 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 9, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
89a8c2a 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 10, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
8aa79e9 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 11, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
8f4b230 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 12, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
1e55eb7 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 13, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
17eb79b 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 14, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
23db1e3 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 16, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
906ca8c 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 17, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
8c7593d 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 18, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
7b7c9a4 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 19, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
ff857ee 
This reverts commit 82a12e1.
zhztheplayer pushed a commit to oap-project/velox that referenced this pull request Jul 23, 2024
@marin-ma @zhztheplayer
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
054b633 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 24, 2024
@marin-ma
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
454e579 
This reverts commit 82a12e1.
zhztheplayer pushed a commit to oap-project/velox that referenced this pull request Jul 25, 2024
@marin-ma @zhztheplayer
Revert "Remove setup-centos8.sh (facebookincubator#10249)"
fc86e77 
This reverts commit 82a12e1.
FelixYBW pushed a commit to oap-project/velox that referenced this pull request Jul 25, 2024
@marin-ma @FelixYBW
[oap ] Revert "Remove setup-centos8.sh (facebookincubator#10249)"
5e5bb9f 
This reverts commit 82a12e1.
GlutenPerfBot pushed a commit to oap-project/velox that referenced this pull request Jul 25, 2024
@marin-ma
[oap ] Revert "Remove setup-centos8.sh (facebookincubator#10249)"
b00a570 
This reverts commit 82a12e1.
@majetideepak majetideepak deleted the remove-centos-8 branch September 30, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr approved these changes

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@majetideepak @facebook-github-bot @bikramSingh91 @kgpai @czentgr