Refactor time point boundary check code #10587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D60322812 |
kagamiori
approved these changes
Jul 29, 2024
| VELOX_ASSERT_THROW(tryLocalYear(year(int(year::max()) + 1)), expected); | ||
| VELOX_ASSERT_THROW(tryLocalYear(year(int(year::min()) - 1)), expected); | ||
|
|
||
| // This time point triggers and assertion failure in external/date. Make sure |
There was a problem hiding this comment.
typo: and assertion failure -> an assertion failure.
|
This pull request was exported from Phabricator. Differential Revision: D60322812 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: facebookincubator#10587 Refactor time point boundary check code to make it less fragmented, and adding more tests. Reviewed By: kagamiori Differential Revision: D60322812
pedroerp
force-pushed
the
export-D60322812
branch
from
224f9eb
to
0cde9fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60322812 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: facebookincubator#10587 Refactor time point boundary check code to make it less fragmented, and adding more tests. Reviewed By: kagamiori Differential Revision: D60322812
pedroerp
force-pushed
the
export-D60322812
branch
from
0cde9fb
to
ce9e114
Compare
Summary: Pull Request resolved: facebookincubator#10587 Refactor time point boundary check code to make it less fragmented, and adding more tests. Reviewed By: kagamiori Differential Revision: D60322812
|
This pull request was exported from Phabricator. Differential Revision: D60322812 |
pedroerp
force-pushed
the
export-D60322812
branch
from
ce9e114
to
24cfba9
Compare
|
This pull request has been merged in 98edcd7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor time point boundary check code to make it less fragmented,
and adding more tests.
Differential Revision: D60322812