Remove core::Config class and its usages #10756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tanjialiang
changed the title
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 14, 2024
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
tanjialiang
force-pushed
the
remove_config
branch
from
8dc6577
to
fb6b179
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 14, 2024
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
tanjialiang
force-pushed
the
remove_config
branch
from
fb6b179
to
2b69185
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 14, 2024
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
tanjialiang
force-pushed
the
remove_config
branch
from
2b69185
to
3357687
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 14, 2024
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
tanjialiang
force-pushed
the
remove_config
branch
from
3357687
to
e95d611
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 14, 2024
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
tanjialiang
force-pushed
the
remove_config
branch
from
e95d611
to
9c73ce0
Compare
tanjialiang
changed the title
Summary: As a config migration effort, remove core::Config class as all dependencies have migrated as of now. Pull Request resolved: facebookincubator#10756 Differential Revision: D61272598 Pulled By: tanjialiang
|
This pull request was exported from Phabricator. Differential Revision: D61272598 |
tanjialiang
force-pushed
the
remove_config
branch
from
9c73ce0
to
15e1e8e
Compare
xiaoxmeng
approved these changes
Aug 15, 2024
|
@tanjialiang merged this pull request in 4fdc4d4. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a config migration effort, remove core::Config class as all dependencies have migrated as of now.