Support date-type partition filter #9937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
May 27, 2024
|
@rui-mo Can you rebase to get rid of build failure? |
rui-mo
force-pushed
the
wip_date_filter
branch
2 times, most recently
from
18f27d9
to
9d5c1a3
Compare
|
@Yuhta The CI passes. Would you take another look? Thanks! |
Yuhta
approved these changes
May 29, 2024
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: When the partition column is of date type and a filter is applied on it, below error occurs when trying to convert date string as int. This PR fixes this exception by utilizing castFromDateString with standard cast behavior. ``` C++ exception with description "Exception: VeloxRuntimeError Error Source: RUNTIME Error Code: INVALID_STATE Reason: Operator::getOutput failed for [operator: TableScan, plan node ID: 0]: Non-whitespace character found after end of conversion: "-10-27" ``` facebookincubator#7084 Pull Request resolved: facebookincubator#9937 Reviewed By: pedroerp Differential Revision: D57913463 Pulled By: Yuhta fbshipit-source-id: 7956de4ae122b080ecf80a96cfcf546f8aae7efe
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: When the partition column is of date type and a filter is applied on it, below error occurs when trying to convert date string as int. This PR fixes this exception by utilizing castFromDateString with standard cast behavior. ``` C++ exception with description "Exception: VeloxRuntimeError Error Source: RUNTIME Error Code: INVALID_STATE Reason: Operator::getOutput failed for [operator: TableScan, plan node ID: 0]: Non-whitespace character found after end of conversion: "-10-27" ``` facebookincubator#7084 Pull Request resolved: facebookincubator#9937 Reviewed By: pedroerp Differential Revision: D57913463 Pulled By: Yuhta fbshipit-source-id: 7956de4ae122b080ecf80a96cfcf546f8aae7efe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the partition column is of date type and a filter is applied on it, below
error occurs when trying to convert date string as int. This PR fixes this
exception by utilizing castFromDateString with standard cast behavior.
#7084