replacing tokenize by split_words_on_whitespace to keep text structure #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zpapakipos
requested changes
Mar 11, 2022
There was a problem hiding this comment.
Hi @AghilesAzzoug, thanks for this PR and for surfacing this issue! Please remove all the formatting changes you made in this PR (probably by running black or some other formatting which doesn't match the ones we use). Once that is done then we can more easily review the actual changes you made. Thanks!
|
@zpapakipos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zpapakipos
pushed a commit
to zpapakipos/AugLy
that referenced
this pull request
Mar 28, 2022
facebookresearch#201) Summary: ## Related Issue Fixes facebookresearch#200 - [ x ] I have read CONTRIBUTING.md to understand how to contribute to this repository :) Replaced `tokenize` and `detokenize` functions by `split_words_on_whitespace` and `rejoin_words_and_whitespace`. ## Unit Tests ### Text Replaced expected strings in unit test using `ReplaceSimilarChars`. All tests passed. Pull Request resolved: facebookresearch#201 Reviewed By: jbitton Differential Revision: D34819291 Pulled By: zpapakipos fbshipit-source-id: 3174900eb7823c1b4df535cbf90edcaf3cadafdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #200
Summary
Replaced
tokenizeanddetokenizefunctions bysplit_words_on_whitespaceandrejoin_words_and_whitespace.Unit Tests
Text
Replaced expected strings in unit test using
ReplaceSimilarChars.All tests passed.